Differential D16420

Keep setIcon() working for now on PHUIObjectItemView
ClosedPublic
Actions

Authored by epriestley on Aug 19 2016, 11:55 AM.

Details

Reviewers

chad

Maniphest Tasks

T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView

Commits

rP1ecce605890c: Keep setIcon() working for now on PHUIObjectItemView

Summary

Ref T11501. This method was removed in D16418, but still has some callsites. I know of four:

Config
Settings
Drydock main page
Almanac main page

Since I might be missing some and it's close to the release cut, just put the method back for now until we can clean it up more properly.

Test Plan

Viewed Settings, Config, Drydock, Almanac. No more fatal on this method being missing.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39487.Aug 19 2016, 11:55 AM

epriestley retitled this revision from to Keep setIcon() working for now on PHUIObjectItemView.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.

epriestley mentioned this in T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.Aug 19 2016, 11:56 AM

I'll fix tho proper when I get back from schools

This revision is now accepted and ready to land.Aug 19 2016, 1:42 PM

Closed by commit rP1ecce605890c: Keep setIcon() working for now on PHUIObjectItemView (authored by epriestley, committed by epriestley). · Explain WhyAug 19 2016, 2:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIObjectItemView.php

5 lines

Diff 39488

View Options

src/view/phui/PHUIObjectItemView.php

Keep setIcon() working for now on PHUIObjectItemViewClosedPublicActions