Page MenuHomePhabricator
Differential D16421

Fix getIcon calls in PHUIObjectListItem
ClosedPublic
Actions

Authored by chad on Aug 19 2016, 4:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 11:44 PM
Unknown Object (File)
Sun, Apr 7, 5:26 PM
Unknown Object (File)
Fri, Apr 5, 2:50 AM
Unknown Object (File)
Mon, Apr 1, 7:02 AM
Unknown Object (File)
Feb 16 2024, 6:23 PM
Unknown Object (File)
Feb 16 2024, 1:23 PM
Unknown Object (File)
Jan 28 2024, 2:10 AM
Unknown Object (File)
Jan 24 2024, 4:45 PM
View All Files
Subscribers
Korvin
Restricted Owners Package

Details

Reviewers
epriestley
Maniphest Tasks
T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView
Commits
rPe7aa874f5eba: Fix getIcon calls in PHUIObjectListItem
Summary

Fixes T11501. Let's you pass in a full PHUIIconView or just the icon name to give ObjectListItem a large icon.

Test Plan

Alamanac, Applications, Drydock, Settings, Search Typeahead, Config page...

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39489.Aug 19 2016, 4:31 PM
chad retitled this revision from to Fix getIcon calls in PHUIObjectListItem.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.
Owners added a subscriber: Restricted Owners Package.Aug 19 2016, 4:31 PM
Herald added a subscriber: Korvin. · View Herald TranscriptAug 19 2016, 4:31 PM
epriestley accepted this revision.Aug 19 2016, 4:34 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 19 2016, 4:34 PM
Closed by commit rPe7aa874f5eba: Fix getIcon calls in PHUIObjectListItem (authored by chad, committed by chad). · Explain WhyAug 19 2016, 4:34 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Aug 19 2016, 4:34 PM

prolly go ahead and roll server in case I missed anything else?

epriestley added a comment.Aug 19 2016, 5:18 PM

Sure, coming up in a sec...

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
controller/
10 lines
config/
controller/
2 lines
drydock/
controller/
8 lines
meta/
query/
14 lines
settings/
query/
4 lines
view/
phui/
9 lines

Diff 39490

View Options

src/applications/almanac/controller/AlmanacConsoleController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigListController.php

Loading...
View Options

src/applications/drydock/controller/DrydockConsoleController.php

Loading...
View Options

src/applications/meta/query/PhabricatorAppSearchEngine.php

Loading...
View Options

src/applications/settings/query/PhabricatorUserPreferencesSearchEngine.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
Phabricator · Built by Phacility