Wrap really long text properly in diffs
ClosedPublic
Actions

Authored by chad on Jun 30 2016, 3:28 AM.

Tags

None

Referenced Files

	F14062558: D16198.diff
	Mon, Nov 18, 12:48 PM

	F14052150: D16198.diff
	Fri, Nov 15, 6:59 AM

	F14035456: D16198.diff
	Sun, Nov 10, 6:03 AM

	F14019947: D16198.diff
	Tue, Nov 5, 11:49 PM

	F14011332: D16198.id38963.diff
	Thu, Oct 31, 10:55 PM

	F14011331: D16198.id38961.diff
	Thu, Oct 31, 10:54 PM

	F14011329: D16198.id.diff
	Thu, Oct 31, 10:54 PM

	F14009690: D16198.diff
	Wed, Oct 30, 10:58 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T11236: Regression: side-by-side diffs: very long lines overflow in diffusion

Commits

rP922822bd2dc3: Wrap really long text properly in diffs

Summary

Fixes T11236, breaks long words and inlines the spans.

Test Plan

Use a diff with super long text like SSH keys, set Font to 24/48 Impact

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 38961.Jun 30 2016, 3:28 AM

chad retitled this revision from to Wrap really long text properly in diffs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11236: Regression: side-by-side diffs: very long lines overflow in diffusion.

Herald added a subscriber: Korvin. · View Herald TranscriptJun 30 2016, 3:28 AM

chad edited the test plan for this revision. (Show Details)Jun 30 2016, 3:28 AM

epriestley accepted this revision.Jun 30 2016, 4:14 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 30 2016, 4:14 AM

Closed by commit rP922822bd2dc3: Wrap really long text properly in diffs (authored by chad, committed by chad). · Explain WhyJun 30 2016, 4:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

css/

core/

syntax.css

3 lines

Diff 38963

View Options

resources/celerity/map.php