Page MenuHomePhabricator
Differential D15562

Don't show continuation lines in "stacked action" comment previews
ClosedPublic
Actions

Authored by epriestley on Apr 1 2016, 1:06 PM.
Tags
None
Referenced Files
F14100059: D15562.diff
Tue, Nov 26, 1:18 PM
Unknown Object (File)
Mon, Nov 25, 10:00 AM
Unknown Object (File)
Sun, Nov 24, 10:52 AM
Unknown Object (File)
Tue, Nov 12, 7:10 AM
Unknown Object (File)
Mon, Nov 11, 6:36 AM
Unknown Object (File)
Sat, Nov 9, 11:43 AM
Unknown Object (File)
Sat, Nov 9, 11:43 AM
Unknown Object (File)
Sat, Nov 9, 11:43 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10698: Comment previews should display user badges under the author's profile image.
Commits
rPad7239d64ccf: Don't show continuation lines in "stacked action" comment previews
Summary

Ref T10698. Currently, we show the spacer/continuation lines around previews, but these don't make sense in previews.

(Other stuff also uses this code so I can't simply remove spacer.)

Test Plan

Before:

Screen Shot 2016-04-01 at 6.05.19 AM.png (248×168 px, 13 KB)

After:

Screen Shot 2016-04-01 at 6.05.26 AM.png (224×216 px, 18 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37515.Apr 1 2016, 1:06 PM
epriestley retitled this revision from to Don't show continuation lines in "stacked action" comment previews.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10698: Comment previews should display user badges under the author's profile image..
chad requested changes to this revision.Apr 1 2016, 2:16 PM
chad edited edge metadata.

legumes

This revision now requires changes to proceed.Apr 1 2016, 2:16 PM
epriestley updated this revision to Diff 37518.Apr 1 2016, 2:20 PM
epriestley edited edge metadata.

blorp

chad accepted this revision.Apr 1 2016, 2:53 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2016, 2:53 PM
Closed by commit rPad7239d64ccf: Don't show continuation lines in "stacked action" comment previews (authored by epriestley, committed by epriestley). · Explain WhyApr 1 2016, 3:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
webroot/
rsrc/
js/
application/
transactions/
5 lines

Diff 37520

View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Loading...
Phabricator · Built by Phacility