Page MenuHomePhabricator
Differential D17480

Add badges to TransactionCommentView
ClosedPublic
Actions

Authored by chad on Mar 7 2017, 10:20 PM.
Tags
None
Referenced Files
F15420868: D17480.id42031.diff
Fri, Mar 21, 6:25 PM
F15419926: D17480.id42032.diff
Fri, Mar 21, 9:57 AM
F15419733: D17480.diff
Fri, Mar 21, 8:28 AM
F15416042: D17480.id.diff
Thu, Mar 20, 8:53 AM
F15412819: D17480.diff
Wed, Mar 19, 3:05 PM
F15411063: D17480.diff
Wed, Mar 19, 8:48 AM
F15408948: D17480.id.diff
Wed, Mar 19, 2:19 AM
F15336161: D17480.diff
Mar 8 2025, 6:19 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10698: Comment previews should display user badges under the author's profile image.
Commits
rP614c8497bb4a: Add badges to TransactionCommentView
Summary

Fixes T10698. This shows badges under the comment preview if the application uses TransactionCommentView. I suspect not everything does, but will pick the fix up for free when modernized.

Test Plan

Test commenting on a task with and without a user that has a badge. See badge preview.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Mar 7 2017, 10:20 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMar 7 2017, 10:20 PM
Harbormaster completed remote builds in B15937: Diff 42031.Mar 7 2017, 10:21 PM
epriestley accepted this revision.Mar 7 2017, 11:56 PM
This revision is now accepted and ready to land.Mar 7 2017, 11:56 PM
Closed by commit rP614c8497bb4a: Add badges to TransactionCommentView (authored by chad, committed by chad). · Explain WhyMar 7 2017, 11:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
view/
47 lines

Diff 42032

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
Phabricator · Built by Phacility