Page MenuHomePhabricator
Differential D17480

Add badges to TransactionCommentView
ClosedPublic
Actions

Authored by chad on Mar 7 2017, 10:20 PM.
Tags
None
Referenced Files
F18105584: D17480.diff
Sun, Aug 10, 6:50 PM
F18094445: D17480.diff
Thu, Aug 7, 10:08 PM
F18074759: D17480.id42032.diff
Mon, Aug 4, 5:51 PM
F18028486: D17480.id42031.diff
Sat, Aug 2, 10:54 PM
F17951856: D17480.id42031.diff
Fri, Aug 1, 1:47 AM
F17948265: D17480.id42032.diff
Thu, Jul 31, 8:38 PM
F17868909: D17480.id.diff
Mon, Jul 28, 10:03 AM
F17854559: D17480.diff
Sun, Jul 27, 3:15 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10698: Comment previews should display user badges under the author's profile image.
Commits
rP614c8497bb4a: Add badges to TransactionCommentView
Summary

Fixes T10698. This shows badges under the comment preview if the application uses TransactionCommentView. I suspect not everything does, but will pick the fix up for free when modernized.

Test Plan

Test commenting on a task with and without a user that has a badge. See badge preview.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Mar 7 2017, 10:20 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMar 7 2017, 10:20 PM
Harbormaster completed remote builds in B15937: Diff 42031.Mar 7 2017, 10:21 PM
epriestley accepted this revision.Mar 7 2017, 11:56 PM
This revision is now accepted and ready to land.Mar 7 2017, 11:56 PM
Closed by commit rP614c8497bb4a: Add badges to TransactionCommentView (authored by chad, committed by chad). · Explain WhyMar 7 2017, 11:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
view/
47 lines

Diff 42032

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
Phabricator · Built by Phacility