Page MenuHomePhabricator

Always parse the first line of a commit message as a title
ClosedPublic

Authored by epriestley on Jan 1 2017, 4:30 PM.

Details

Summary

Fixes T10312. If your first line is "Reviewers: xyz", it's a title, not a "Reviewers" field.

Test Plan

Added unit test.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

src/applications/differential/parser/DifferentialCommitMessageParser.php
178

This is for T6050, I'll provide some context there.

This revision is now accepted and ready to land.Jan 1 2017, 5:31 PM
This revision was automatically updated to reflect the committed changes.