Page MenuHomePhabricator

Always parse the first line of a commit message as a title
ClosedPublic

Authored by epriestley on Jan 1 2017, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 17, 12:54 AM
Unknown Object (File)
Sun, Jun 15, 9:36 PM
Unknown Object (File)
May 29 2025, 9:38 AM
Unknown Object (File)
May 29 2025, 8:55 AM
Unknown Object (File)
May 28 2025, 8:48 AM
Unknown Object (File)
May 27 2025, 9:55 PM
Unknown Object (File)
May 10 2025, 2:46 AM
Unknown Object (File)
Apr 23 2025, 8:45 PM
Subscribers
None

Details

Summary

Fixes T10312. If your first line is "Reviewers: xyz", it's a title, not a "Reviewers" field.

Test Plan

Added unit test.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/differential/parser/DifferentialCommitMessageParser.php
179

This is for T6050, I'll provide some context there.

This revision is now accepted and ready to land.Jan 1 2017, 5:31 PM
This revision was automatically updated to reflect the committed changes.