Page MenuHomePhabricator
Differential D9999

Rename auth classes for consistency
ClosedPublic
Actions

Authored by joshuaspence on Jul 21 2014, 3:26 PM.
Tags
None
Referenced Files
F19152590: D9999.diff
Thu, Dec 11, 3:54 AM
F19047653: D9999.id.diff
Thu, Nov 27, 1:12 PM
F18854190: D9999.diff
Oct 31 2025, 10:13 PM
F18835113: D9999.id.diff
Oct 26 2025, 1:24 PM
F18832704: D9999.diff
Oct 25 2025, 10:42 PM
F18808652: D9999.id24058.diff
Oct 19 2025, 7:41 AM
F18808651: D9999.id24034.diff
Oct 19 2025, 7:41 AM
F18740502: D9999.id24034.diff
Oct 2 2025, 3:51 AM
View All Files
Subscribers
20after4
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5655: Standardize naming conventions
Commits
Restricted Diffusion Commit
rP701bb2ac6ec9: Rename auth classes for consistency
Summary

Ref T5655. Depends on D9998.

Test Plan

arc unit

Diff Detail

Repository
rP Phabricator
Branch
renameauth
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1811
Build 1812: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 24034.Jul 21 2014, 3:26 PM
joshuaspence retitled this revision from to Rename auth classes for consistency.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5655: Standardize naming conventions.
joshuaspence added a parent revision: D9998: Rename auth classes for consistency.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 21 2014, 3:26 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1811: Diff 24034.Jul 21 2014, 3:27 PM
epriestley accepted this revision.Jul 21 2014, 3:43 PM
epriestley edited edge metadata.
epriestley added a subscriber: 20after4.

@20after4, heads up that you might need to change an extends ACB to extends ABC. We're fixing a general inconsistency in class names, see T5655 for some details.

This revision is now accepted and ready to land.Jul 21 2014, 3:43 PM
joshuaspence closed this revision.Jul 22 2014, 11:04 AM
joshuaspence updated this revision to Diff 24058.

Closed by commit rP701bb2ac6ec9 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
68 lines
applications/
auth/
provider/
PhabricatorAmazonAuthProvider.php
PhabricatorAuthProviderOAuthAmazon.php
6 lines
PhabricatorAsanaAuthProvider.php
PhabricatorAuthProviderOAuthAsana.php
7 lines
PhabricatorBitbucketAuthProvider.php
PhabricatorAuthProviderOAuth1Bitbucket.php
6 lines
PhabricatorDisqusAuthProvider.php
PhabricatorAuthProviderOAuthDisqus.php
6 lines
PhabricatorFacebookAuthProvider.php
PhabricatorAuthProviderOAuthFacebook.php
6 lines
PhabricatorGitHubAuthProvider.php
PhabricatorAuthProviderOAuthGitHub.php
6 lines
PhabricatorGoogleAuthProvider.php
PhabricatorAuthProviderOAuthGoogle.php
6 lines
PhabricatorJIRAAuthProvider.php
PhabricatorAuthProviderOAuth1JIRA.php
7 lines
PhabricatorLDAPAuthProvider.php
PhabricatorAuthProviderLDAP.php
7 lines
PhabricatorOAuth1AuthProvider.php
PhabricatorAuthProviderOAuth1.php
6 lines
PhabricatorOAuth2AuthProvider.php
PhabricatorAuthProviderOAuth2.php
6 lines
PhabricatorOAuthAuthProvider.php
PhabricatorAuthProviderOAuth.php
2 lines
PhabricatorPasswordAuthProvider.php
PhabricatorAuthProviderPassword.php
3 lines
PhabricatorPersonaAuthProvider.php
PhabricatorAuthProviderPersona.php
5 lines
PhabricatorTwitchAuthProvider.php
PhabricatorAuthProviderOAuthTwitch.php
6 lines
PhabricatorTwitterAuthProvider.php
PhabricatorAuthProviderOAuth1Twitter.php
6 lines
PhabricatorWordPressAuthProvider.php
PhabricatorAuthProviderOAuthWordPress.php
6 lines

Diff 24034

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAmazonAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAsanaAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderLDAP.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuth.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuth1.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuth1Bitbucket.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuth1JIRA.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuth1Twitter.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuth2.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuthAmazon.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuthAsana.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuthDisqus.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuthFacebook.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuthGitHub.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuthGoogle.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuthTwitch.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuthWordPress.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderPassword.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderPersona.php

Loading...
View Options

src/applications/auth/provider/PhabricatorBitbucketAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorDisqusAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorFacebookAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorGitHubAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorGoogleAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorJIRAAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorLDAPAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorOAuthAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorPasswordAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorPersonaAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorTwitchAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorTwitterAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorWordPressAuthProvider.php

Loading...
Phabricator · Built by Phacility