HomePhabricator

Simplify the implementation of `PhabricatorPHIDType` subclasses

Description

Simplify the implementation of PhabricatorPHIDType subclasses

Summary: Instead of implementing the getTypeConstant method in all subclasses of PhabricatorPHIDType, provide a final implementation in the base class which uses reflection. See D9837 for a similar implementation.

Test Plan: Ran arc unit.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D9985

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Jul 21 2014, 2:38 PM
Reviewer
Blessed Reviewers
Differential Revision
D9985: Simplify the implementation of `PhabricatorPHIDType` subclasses
Parents
rP37106c1b3178: Don't explicitly name abstract base classes
Branches
Unknown
Tags
Unknown

Event Timeline