Page MenuHomePhabricator

Use have/need data in ArcanistPhutilLibraryLinter
ClosedPublic

Authored by epriestley on Jul 16 2014, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 3:05 PM
Unknown Object (File)
Sun, Dec 15, 11:16 AM
Unknown Object (File)
Sun, Dec 15, 11:16 AM
Unknown Object (File)
Sun, Dec 15, 11:16 AM
Unknown Object (File)
Sun, Dec 15, 11:09 AM
Unknown Object (File)
Thu, Dec 12, 12:28 PM
Unknown Object (File)
Thu, Dec 12, 1:21 AM
Unknown Object (File)
Mon, Dec 9, 11:31 AM
Subscribers

Details

Summary

Ref T5640. In D9864, the data this linter pulls out of the map was changed, breaking "use of undeclared function" warnings.

Test Plan
>>> Lint for src/future/FutureProxy.php:


   Error  (PHL1) Unknown Symbol
    Use of unknown function 'qqqqqq'. Common causes are:
    
      - Your libphutil/ is out of date.
        This is the most common cause.
        Update this copy of libphutil: /INSECURE/devtools/libphutil
    
      - Some other library is out of date.
        Update the library this symbol appears in.
    
      - This symbol is misspelled.
        Spell the symbol name correctly.
        Symbol name spelling is case-sensitive.
    
      - This symbol was added recently.
        Run `arc liberate` on the library it was added to.
    
      - This symbol is external. Use `@phutil-external-symbol`.
        Use `grep` to find usage examples of this directive.
    
    *** ALTHOUGH USUALLY EASY TO FIX, THIS IS A SERIOUS ERROR.
    *** THIS ERROR IS YOUR FAULT. YOU MUST RESOLVE IT.

              15       $this->setProxiedFuture($proxied);
              16     }
              17 
    >>>       18     qqqqqq();
              19   }
              20 
              21   public function setProxiedFuture(Future $proxied) {

Diff Detail

Repository
rARC Arcanist
Branch
pllint
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 1729
Build 1730: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestPyLintLinter
0 mstestCSSLintLinter
0 mstestFixLetterCase
0 mstestFlake8Lint
0 mstestJSHintLinter
View Full Test Results (1 Failed · 16 Passed · 8 Skipped)

Event Timeline

epriestley retitled this revision from to Use have/need data in ArcanistPhutilLibraryLinter.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.

(I'm going to create a new maniphest task for this so we can link to something more relevant than T1806: Move Aphront to libphutil)

Is it possible to add unit tests for this linter? *unsure*

I don't see a practical way to do it. I think this break was kind of a fluke.

This revision is now accepted and ready to land.Jul 17 2014, 9:19 PM
epriestley updated this revision to Diff 23914.

Closed by commit rARCc6e6227ef9bf (authored by @epriestley).