HomePhabricator

Remove "Stopped" logic from Phrequent workflows

Description

Remove "Stopped" logic from Phrequent workflows

Summary: We can remove this "Stopped" code as per feedback on D7327. I think having the full text of "In Progress" and "Suspended" is much clearer than just a '*' though, so I've only removed the ongoing check.

Test Plan: Ran a combination of arc start, arc stop and arc time and it all worked.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9955

Details

Auditors
hach-que
vivek_saini07
Provenance
hach-queAuthored on
hach-quePushed on Jul 17 2014, 3:26 AM
Reviewer
Blessed Reviewers
Differential Revision
D9955: Remove "Stopped" logic from Phrequent workflows
Parents
rARCf658f170808e: Add Phrequent workflows to Arcanist
Branches
Unknown
Tags
Unknown

Event Timeline

vivek_saini07 added inline comments.
/src/workflow/ArcanistPhrequentWorkflow.php
53

this is not good

55

WTF? Don't do it again.

64

This is awesome

69

Good work