Paths

Table of Contentst

Differential D9864

Minor change to `ArcanistPhutilLibraryLinter`
ClosedPublic
Actions

Authored by joshuaspence on Jul 9 2014, 9:19 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5577: `ArcanistPhutilLibraryLinter` causes `arc lint` to die if there is a PHP syntax error

Commits

rARCe37a76896a08: Minor change to `ArcanistPhutilLibraryLinter`

Summary

Ref T5577. Modify ArcanistPhutilLibraryLinter to use PhutilLibraryMapBuilder instead of using an ExecFuture to run phutil_rebuild_map.php.

Test Plan

Ran arc lint.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23664.Jul 9 2014, 9:19 PM

joshuaspence retitled this revision from to Minor change to `ArcanistPhutilLibraryLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5577: `ArcanistPhutilLibraryLinter` causes `arc lint` to die if there is a PHP syntax error.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 9 2014, 9:19 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1591: Diff 23664.Jul 9 2014, 9:20 PM

epriestley accepted this revision.Jul 9 2014, 9:35 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/lint/linter/ArcanistPhutilLibraryLinter.php
59–60	Now unused?

This revision is now accepted and ready to land.Jul 9 2014, 9:35 PM

Closed by commit rARCe37a76896a08 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhutilLibraryLinter.php

18 lines

Diff 23670

View Options

src/lint/linter/ArcanistPhutilLibraryLinter.php

Minor change to `ArcanistPhutilLibraryLinter`ClosedPublicActions