Expose the file symbol map from PhutilLibraryMapBuilder
ClosedPublic
Actions

Authored by epriestley on Jul 16 2014, 10:55 PM.

Details

Reviewers

joshuaspence

Maniphest Tasks

T5640: Detect the use of undefined classes/functions during linting

Commits

rPHU859c41d4fb07: Expose the file symbol map from PhutilLibraryMapBuilder

Summary

Ref T5640. In D9864, collection of output from phutil_symbols.php (which includes symbols that things use) was replaced with processed output (which does not).

Allow callers (notably, ArcanistPhutilLibraryLinter) to access the raw have/need data.

Test Plan

See D9954.

Diff Detail

Repository

rPHU libphutil

Branch

filesymbolamp

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1731
Build 1732: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23886.Jul 16 2014, 10:55 PM

epriestley retitled this revision from to Expose the file symbol map from PhutilLibraryMapBuilder.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

epriestley added a task: T1806: Move Aphront to libphutil.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 16 2014, 10:55 PM

Harbormaster completed remote builds in B1728: Diff 23886.Jul 16 2014, 10:56 PM

(This isn't really related to T1806)

joshuaspence updated this object.Jul 16 2014, 11:05 PM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.

joshuaspence added a task: T5640: Detect the use of undefined classes/functions during linting.

joshuaspence removed a task: T1806: Move Aphront to libphutil.

This feels a little messy, particularly because buildMap is a pretty big function and probably needs to be broken up further. I feel like we should perhaps rename the buildMap function to build and make it private and then expose two functions like buildLibraryMap and buildFileSymbolMap instead.

If you don't want to do this now, then I'm willing to accept this diff now and we can clean it up later.

WARNING: I could be talking complete nonsense as I just returned from overseas and am a little jetlagged.