HomePhabricator

Minor improvement to XHPASTSyntaxErrorException message

Description

Minor improvement to XHPASTSyntaxErrorException message

Summary: Trim trailing newline from exception message.

Test Plan:
Before

> ./scripts/phutil_symbols.php test.php
{
  "error" : "XHPAST Parse Error: syntax error, unexpected $end, expecting T_FUNCTION on line 4\n",
  "line"  : "4",
  "file"  : "\/home\/joshua\/workspace\/github.com\/phacility\/libphutil\/foo.php"
}

After

> ./scripts/phutil_symbols.php test.php
{
  "error" : "XHPAST Parse Error: syntax error, unexpected $end, expecting T_FUNCTION on line 4",
  "line"  : "4",
  "file"  : "\/home\/joshua\/workspace\/github.com\/phacility\/libphutil\/foo.php"
}

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9961

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Jul 17 2014, 9:33 PM
Reviewer
Blessed Reviewers
Differential Revision
D9961: Minor improvement to XHPASTSyntaxErrorException message
Parents
rPHU1f274ecd632b: Minor changes to `phutiltestlib`
Branches
Unknown
Tags
Unknown

Event Timeline