Page MenuHomePhabricator
Differential D9865

Allow the `ArcanistPhutilLibraryLinter` to recover from PHP syntax errors
ClosedPublic
Actions

Authored by joshuaspence on Jul 9 2014, 9:53 PM.
Tags
None
Referenced Files
F13235327: D9865.id.diff
Tue, May 21, 4:41 AM
F13231502: D9865.diff
Tue, May 21, 12:31 AM
F13230959: D9865.id.diff
Mon, May 20, 11:28 PM
F13188615: D9865.diff
Sat, May 11, 5:22 AM
F13182186: D9865.diff
Thu, May 9, 8:44 PM
Unknown Object (File)
Tue, May 7, 7:23 AM
Unknown Object (File)
Fri, May 3, 7:50 AM
Unknown Object (File)
Thu, May 2, 10:57 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5577: `ArcanistPhutilLibraryLinter` causes `arc lint` to die if there is a PHP syntax error
Commits
rARC3de9e4aaea61: Allow the `ArcanistPhutilLibraryLinter` to recover from PHP syntax errors
Summary

Fixes T5577. If the ArcanistPhutilLibraryLinter lints a PHP file that contains a syntax error, it will die horribly. Instead, force it to continue as if nothing was wrong.

Test Plan

Introduced a PHP syntax error. Ran arc lint and made sure the output looked reasonable.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23671.Jul 9 2014, 9:53 PM
joshuaspence retitled this revision from to Allow the `ArcanistPhutilLibraryLinter` to recover from PHP syntax errors.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5577: `ArcanistPhutilLibraryLinter` causes `arc lint` to die if there is a PHP syntax error.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 9 2014, 9:53 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1594: Diff 23671.Jul 9 2014, 9:54 PM
epriestley accepted this revision.Jul 9 2014, 9:58 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 9:58 PM
joshuaspence added a comment.Jul 9 2014, 9:59 PM

Oh whoops, there's a change that needs to be made in rPHU as well. Coming right up.

joshuaspence added a parent revision: D9867: Throw an exception instead of exiting.Jul 9 2014, 10:02 PM
joshuaspence closed this revision.Jul 10 2014, 1:49 AM
joshuaspence updated this revision to Diff 23686.

Closed by commit rARC3de9e4aaea61 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
9 lines

Diff 23686

View Options

src/lint/linter/ArcanistPhutilLibraryLinter.php

Loading...
Phabricator · Built by Phacility