Page MenuHomePhabricator

Allow the `ArcanistPhutilLibraryLinter` to recover from PHP syntax errors
ClosedPublic

Authored by joshuaspence on Jul 9 2014, 9:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 5:57 PM
Unknown Object (File)
Sun, Dec 15, 12:24 PM
Unknown Object (File)
Fri, Dec 13, 8:45 PM
Unknown Object (File)
Tue, Dec 10, 1:18 PM
Unknown Object (File)
Sat, Dec 7, 1:19 AM
Unknown Object (File)
Tue, Dec 3, 2:18 PM
Unknown Object (File)
Tue, Dec 3, 1:59 PM
Unknown Object (File)
Mon, Dec 2, 11:44 AM
Subscribers

Details

Summary

Fixes T5577. If the ArcanistPhutilLibraryLinter lints a PHP file that contains a syntax error, it will die horribly. Instead, force it to continue as if nothing was wrong.

Test Plan

Introduced a PHP syntax error. Ran arc lint and made sure the output looked reasonable.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Allow the `ArcanistPhutilLibraryLinter` to recover from PHP syntax errors.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 9:58 PM

Oh whoops, there's a change that needs to be made in rPHU as well. Coming right up.