Differential D9867

Throw an exception instead of exiting
ClosedPublic
Actions

Authored by joshuaspence on Jul 9 2014, 10:02 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5577: `ArcanistPhutilLibraryLinter` causes `arc lint` to die if there is a PHP syntax error

Commits

rPHU59fa2f8e3910: Throw an exception instead of exiting

Summary

Ref T5577. The PhutilLibraryMapBuilder should throw a XHPASTSyntaxErrorException exception instead of calling exit.

Test Plan

See D9865.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23673.Jul 9 2014, 10:02 PM

joshuaspence retitled this revision from to Throw an exception instead of exitting.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5577: `ArcanistPhutilLibraryLinter` causes `arc lint` to die if there is a PHP syntax error.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 9 2014, 10:02 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1596: Diff 23673.Jul 9 2014, 10:03 PM

epriestley accepted this revision.Jul 9 2014, 10:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 9 2014, 10:06 PM

joshuaspence retitled this revision from Throw an exception instead of exitting to Throw an exception instead of exiting.Jul 10 2014, 1:42 AM

joshuaspence edited edge metadata.

Closed by commit rPHU59fa2f8e3910 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

moduleutils/

PhutilLibraryMapBuilder.php

5 lines

Diff 23685

View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Throw an exception instead of exitingClosedPublicActions