Page MenuHomePhabricator

Allow the `ArcanistPhutilLibraryLinter` to recover from PHP syntax errors
ClosedPublic

Authored by joshuaspence on Jul 9 2014, 9:53 PM.
Tags
None
Referenced Files
F21054462: D9865.diff
Tue, Jun 30, 12:16 PM
Unknown Object (File)
Mon, Jun 8, 12:41 AM
Unknown Object (File)
Apr 11 2026, 11:17 PM
Unknown Object (File)
Mar 6 2026, 11:52 PM
Unknown Object (File)
Mar 6 2026, 10:00 PM
Unknown Object (File)
Mar 4 2026, 9:16 PM
Unknown Object (File)
Feb 19 2026, 10:16 AM
Unknown Object (File)
Feb 11 2026, 9:26 AM
Subscribers

Details

Summary

Fixes T5577. If the ArcanistPhutilLibraryLinter lints a PHP file that contains a syntax error, it will die horribly. Instead, force it to continue as if nothing was wrong.

Test Plan

Introduced a PHP syntax error. Ran arc lint and made sure the output looked reasonable.

Diff Detail

Repository
rARC Arcanist
Branch
phutillint
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1594
Build 1595: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Allow the `ArcanistPhutilLibraryLinter` to recover from PHP syntax errors.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 9:58 PM

Oh whoops, there's a change that needs to be made in rPHU as well. Coming right up.