Fixes T5300. Currently, if a dead symbolic link is linted, all kinds of errors will be thrown by most linters because they will try to read the (non-existent) file contents. Instead, let's not lint symbolic links by default. In the case that the target of a symbolic link is inside the working copy, then it should be being linted anyway.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5300: Don't lint symbolic links
- Commits
- rARC02e3905cf50a: Don't lint symlinks by default.
Created a symbolic link and verified that it wasn't linted (by any linter other than the ArcanistFilenameLinter).
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- shouldlintsymlinks
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 983 Build 983: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
One inline -- can you verify that it doesn't cause problems?
| src/lint/engine/ArcanistLintEngine.php | ||
|---|---|---|
| 194 | I would expect this to need to call getFilePathOnDisk() and test that, particularly if arc lint is run from a subdirectory. | |
| src/lint/engine/ArcanistLintEngine.php | ||
|---|---|---|
| 194 | Yeah of course... I run arc from the project root 99% of the test and so often forget about things like this. | |
Comment Actions
Closed by commit rARC02e3905cf50a (authored by @joshuaspence, committed by @epriestley).