HomePhabricator

Allow spaces after the `.` operator if followed by a comment.

Description

Allow spaces after the . operator if followed by a comment.

Summary: Currently, 'foo'. // Some comment is not allowed by the ArcanistXHPASTLinter::LINT_BINARY_EXPRESSION_SPACING rule. I believe that in the case of a trailing comment, we should allow whitespace after the . operator.

Test Plan: Wrote and executed a unit test for this case.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9438

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on Jun 9 2014, 7:25 PM
epriestleyPushed on Jun 9 2014, 7:25 PM
Reviewer
Blessed Reviewers
Differential Revision
D9438: Allow spaces after the `.` operator if followed by a comment.
Parents
rARC833ce4515566: Lint the `ArcanistSpellingDefaultData` class.
Branches
Unknown
Tags
Unknown

Event Timeline