Page MenuHomePhabricator

Don't lint symbolic links
Closed, ResolvedPublic

Description

It would be somewhat useful if there were a symbolic link linter which could find dead symbolic links and complain about them.

Event Timeline

joshuaspence claimed this task.
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence triaged this task as Low priority.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Arcanist.
joshuaspence added a subscriber: joshuaspence.

This seems maybe-perilous because a symlink might point outside the working copy, or might point at an external/submodule which hasn't been initialized. I'd worry false positives like this might overwhelm true positives. That said, this .arclint makes it fairly easy to deal with this kind of stuff with exclusion/inclusion rules.

Possibly, one real issue at the moment however, is that arc lint will fail to lint these files altogether (none of the linters will be able to read the contents of such a file).

joshuaspence renamed this task from Add a symbolic link linter to Don't lint symbolic links.Jun 10 2014, 12:04 AM