HomePhabricator

Don't lint symlinks by default.

Description

Don't lint symlinks by default.

Summary: Fixes T5300. Currently, if a dead symbolic link is linted, all kinds of errors will be thrown by most linters because they will try to read the (non-existent) file contents. Instead, let's not lint symbolic links by default. In the case that the target of a symbolic link is inside the working copy, then it should be being linted anyway.

Test Plan: Created a symbolic link and verified that it wasn't linted (by any linter other than the ArcanistFilenameLinter).

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T5300

Differential Revision: https://secure.phabricator.com/D9448

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on Jun 11 2014, 1:20 AM
epriestleyPushed on Jun 11 2014, 1:21 AM
Reviewer
Blessed Reviewers
Differential Revision
D9448: Don't lint symlinks by default.
Parents
rARCff1915ecff28: Apply various linter fixes.
Branches
Unknown
Tags
Unknown
Tasks
T5300: Don't lint symbolic links

Event Timeline