Page MenuHomePhabricator

Remove a parameter
ClosedPublic

Authored by sowedance on Mar 6 2014, 11:51 PM.
Tags
None
Referenced Files
F15530395: D8432.id20016.diff
Wed, Apr 23, 3:31 AM
F15527867: D8432.id.diff
Tue, Apr 22, 7:09 AM
F15525340: D8432.diff
Mon, Apr 21, 1:42 PM
F15511958: D8432.id20015.diff
Thu, Apr 17, 6:57 AM
F15509076: D8432.diff
Wed, Apr 16, 9:21 AM
F15415717: D8432.diff
Mar 20 2025, 7:39 AM
F15405340: D8432.diff
Mar 18 2025, 11:11 AM
Unknown Object (File)
Feb 22 2025, 7:44 PM

Details

Summary

D7271 added this line but the signature of function ArcanistWorkingCopyIdentity::newFromRootAndConfigFile(...) was never changed. I have no idea why it was added here and it's causing failures in facebook. I am just removing it now.

Test Plan

No idea how to test

Diff Detail

Repository
rARC Arcanist
Branch
precommithook
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2014, 11:52 PM