To me, it seems that these methods should never be overwritten in subclasses.
Details
Details
arc lint and arc unit.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
src/workflow/ArcanistBaseWorkflow.php | ||
---|---|---|
1500 | I could imagine something overriding this, adding some $data, and calling the parent, but it should probably wrap it instead if it does. |
Comment Actions
Closed by commit rARCa67b848f4460 (authored by @joshuaspence, committed by @epriestley).
Comment Actions
This again broke our arc workflow. I'll look if it is needed though it would be nice to get a revert.
Is there any particular reason why we are locking these down all of a sudden? It seems like if they stay open then it is on us to to track you, which is a lot easier as we have all the info as to what our code does :D
Comment Actions
FWIW, this is what broke / why we override:
public function getRepositoryAPI() { $repository_api = parent::getRepositoryAPI(); if (!($repository_api instanceof ArcanistGitAPI) && !($repository_api instanceof ArcanistMercurialAPI)) { throw new ArcanistUsageException( 'arc cleanup-features is only supported under Git and Mercurial.'); } return $repository_api;
Comment Actions
There's a much easier way to do that:
protected function getSupportedRevisionControlSystems() { return array('git', 'hg'); }