HomePhabricator

Made some additional methods of `ArcanistBaseWorkflow` final.

Description

Made some additional methods of ArcanistBaseWorkflow final.

Summary: To me, it seems that these methods should never be overwritten in subclasses.

Test Plan: arc lint and arc unit.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: LegNeato, aran, epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D7959

Conflicts:
src/workflow/ArcanistBaseWorkflow.php

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on May 18 2014, 6:05 PM
epriestleyPushed on May 18 2014, 6:06 PM
Reviewer
epriestley
Differential Revision
D7959: Made some additional methods of `ArcanistBaseWorkflow` final.
Parents
rARC6c1bae437e30: Modernize `ArcanistScalaSBTLinter`.
Branches
Unknown
Tags
Unknown

Event Timeline