Paths

Table of Contentst

Made some additional methods of `ArcanistLintEngine` final
ClosedPublic
Actions

Authored by joshuaspence on Jan 14 2014, 7:52 AM.

Tags

None

Referenced Files

	F13816047: D7960.id21815.diff
	Thu, Sep 19, 12:20 PM

	F13816046: D7960.id18007.diff
	Thu, Sep 19, 12:20 PM

	Unknown Object (File)
	Mon, Sep 16, 12:14 AM

	Unknown Object (File)
	Mon, Sep 16, 12:14 AM

	Unknown Object (File)
	Mon, Sep 16, 12:13 AM

	Unknown Object (File)
	Sun, Sep 15, 12:07 PM

	Unknown Object (File)
	Thu, Sep 12, 4:45 PM

	Unknown Object (File)
	Wed, Sep 11, 7:36 PM

Subscribers

Details

Reviewers

epriestley

Commits

rARC606380f4bdce: Made some additional methods of `ArcanistLintEngine` final

Summary

To me, it seems that these methods should not be overridden by subclasses

Test Plan

arc lint and arc unit

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

(These are all probably fine, I'm just waiting until I have some downtime to review them so I can think through things and catch any issues we might have lurking in prior subclasses.)

Fair enough... thanks for the update.

btrahan removed a reviewer: Blessed Reviewers.May 7 2014, 5:20 PM

(+@LegNeato)

These all seem pretty safe to me. I haven't seen users adding much magic to subclasses of LintEngine, either.

This revision is now accepted and ready to land.May 18 2014, 6:08 PM

Closed by commit rARC606380f4bdce (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

engine/

ArcanistLintEngine.php

66 lines

Diff 21815

View Options

src/lint/engine/ArcanistLintEngine.php

Made some additional methods of `ArcanistLintEngine` finalClosedPublicActions