Page MenuHomePhabricator

Made some additional methods of `ArcanistLintEngine` final
ClosedPublic

Authored by joshuaspence on Jan 14 2014, 7:52 AM.
Tags
None
Referenced Files
F15499277: D7960.diff
Sun, Apr 13, 2:47 PM
F15478377: D7960.id18007.diff
Mon, Apr 7, 10:27 PM
F15468883: D7960.id21815.diff
Fri, Apr 4, 7:21 AM
F15380389: D7960.diff
Mar 14 2025, 2:48 AM
F15293635: D7960.id21815.diff
Mar 5 2025, 4:30 AM
F15293630: D7960.id18007.diff
Mar 5 2025, 4:30 AM
Unknown Object (File)
Feb 23 2025, 4:27 AM
Unknown Object (File)
Feb 9 2025, 11:08 AM

Details

Summary

To me, it seems that these methods should not be overridden by subclasses

Test Plan

arc lint and arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

(These are all probably fine, I'm just waiting until I have some downtime to review them so I can think through things and catch any issues we might have lurking in prior subclasses.)

Fair enough... thanks for the update.

epriestley edited edge metadata.
epriestley added a subscriber: LegNeato.

(+@LegNeato)

These all seem pretty safe to me. I haven't seen users adding much magic to subclasses of LintEngine, either.

This revision is now accepted and ready to land.May 18 2014, 6:08 PM
epriestley updated this revision to Diff 21815.

Closed by commit rARC606380f4bdce (authored by @joshuaspence, committed by @epriestley).