Page MenuHomePhabricator

LegNeato (Christian Legnitto)
UserEmail Not Verified

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 20 2013, 1:16 AM (355 w, 23 h)
Availability
Available

Recent Activity

Jun 13 2014

LegNeato closed T5314: Unable to override severities for text linter in new json lint as Invalid.

Ah cool.

Jun 13 2014, 1:52 AM · Arcanist

Jun 11 2014

LegNeato added a comment to T5260: Need a way to define common include/exclude patterns in lint.

Ah, ok. In another task we were told to use the new way :D

Jun 11 2014, 7:00 AM · Arcanist
LegNeato created T5314: Unable to override severities for text linter in new json lint.
Jun 11 2014, 7:00 AM · Arcanist
LegNeato created T5313: Lint hangs when using `arc diff` and ArcanistConfigurationDrivenLintEngine.
Jun 11 2014, 6:56 AM · Arcanist

Jun 4 2014

LegNeato added a comment to T5260: Need a way to define common include/exclude patterns in lint.

The global exclude stuff is actually not for *all* of the linters. We, for example, have linters that make sure vendored in stuff has a LICENSE file, etc. So that doesn't help here :-(

Jun 4 2014, 7:50 PM · Arcanist
LegNeato added a comment to T5260: Need a way to define common include/exclude patterns in lint.

At scale the json format is a huge pain:

Jun 4 2014, 7:40 PM · Arcanist
LegNeato added a comment to T5260: Need a way to define common include/exclude patterns in lint.

A way to support this would be to let .arclint be PHP as well as json. The json is super annoying to deal with, and with PHP we could use variables and such.

Jun 4 2014, 4:30 PM · Arcanist
LegNeato created T5260: Need a way to define common include/exclude patterns in lint.
Jun 4 2014, 4:29 PM · Arcanist

May 19 2014

LegNeato added a comment to D7959: Made some additional methods of `ArcanistBaseWorkflow` final..

FWIW, this is what broke / why we override:

May 19 2014, 6:35 AM
LegNeato added a comment to D7959: Made some additional methods of `ArcanistBaseWorkflow` final..

This again broke our arc workflow. I'll look if it is needed though it would be nice to get a revert.

May 19 2014, 6:30 AM

May 14 2014

LegNeato added a comment to D7958: Made some additional methods of `ArcanistLinter` and `ArcanistExternalLinter` final.

I'm actually revamping our linters and don't think this will be an issue in the future, so let's keep it this way for now. I'll put up a diff if it later becomes an issue.

May 14 2014, 12:51 AM
LegNeato added a comment to D7958: Made some additional methods of `ArcanistLinter` and `ArcanistExternalLinter` final.

We basically do

 // Path regexes to run clang-format on
$whitelist = array(
  // '#^BLAH/.*#',
);
May 14 2014, 12:25 AM

Apr 3 2014

LegNeato created T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits.
Apr 3 2014, 5:27 AM · XHPAST, Arcanist

Mar 28 2014

LegNeato updated subscribers of T4695: Allow regular expressions for tracked branches.
Mar 28 2014, 3:40 AM · Diffusion
LegNeato updated subscribers of T4695: Allow regular expressions for tracked branches.
Mar 28 2014, 3:40 AM · Diffusion