Page MenuHomePhabricator

Fix an issue with 1up diff block rendering for added or removed blocks
ClosedPublic

Authored by epriestley on Nov 8 2019, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 8:25 AM
Unknown Object (File)
Sun, Feb 9, 8:25 AM
Unknown Object (File)
Sun, Feb 9, 8:25 AM
Unknown Object (File)
Sat, Feb 1, 4:00 AM
Unknown Object (File)
Fri, Jan 31, 10:01 PM
Unknown Object (File)
Tue, Jan 28, 1:12 PM
Unknown Object (File)
Sat, Jan 25, 6:06 AM
Unknown Object (File)
Sat, Jan 25, 6:06 AM
Subscribers

Details

Summary

Ref T13425. When a change adds or removes a block (vs adding or removing a document, or changing a block), we currently try to render null as cell content in the unified view. Make this check broader to catch both "no opposite document" and "no opposite cell".

Test Plan

Screen Shot 2019-11-08 at 7.36.31 AM.png (492×1 px, 76 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable