Page MenuHomePhabricator

Fix an issue with 1up diff block rendering for added or removed blocks
ClosedPublic

Authored by epriestley on Fri, Nov 8, 3:35 PM.

Details

Summary

Ref T13425. When a change adds or removes a block (vs adding or removing a document, or changing a block), we currently try to render null as cell content in the unified view. Make this check broader to catch both "no opposite document" and "no opposite cell".

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Nov 8, 3:35 PM
epriestley edited the summary of this revision. (Show Details)Fri, Nov 8, 3:36 PM
epriestley requested review of this revision.Fri, Nov 8, 3:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Nov 8, 3:37 PM
This revision was automatically updated to reflect the committed changes.