Give "bin/config" a friendlier error message if "local.json" is not writable
ClosedPublic
Actions

Authored by epriestley on Sep 3 2019, 7:19 PM.

Details

Reviewers: None
Maniphest Tasks: T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues
Commits: rPd9badba14786: Give "bin/config" a friendlier error message if "local.json" is not writable

Summary

Ref T13403. We currently emit a useful error message, but it's not tailored and has a stack trace. Since this is a relatively routine error and on the first-time-setup path, tailor it so it's a bit nicer.

Test Plan

Ran bin/config set ... with an unwritable "local.json".
Ran bin/config set ... normally.

Diff Detail

Repository

rP Phabricator

Branch

config1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23371
Build 32104: Run Core Tests
Build 32103: arc lint + arc unit

Event Timeline

Slightly cleaner diff.

Harbormaster completed remote builds in B23371: Diff 49545.Sep 3 2019, 7:20 PM

Harbormaster completed remote builds in B23372: Diff 49546.

epriestley requested review of this revision.Sep 3 2019, 7:22 PM

epriestley added a child revision: D20780: When "mysqli->real_connect()" fails without setting an error code, recover more gracefully.Sep 3 2019, 7:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2019, 7:47 PM

Closed by commit rPd9badba14786: Give "bin/config" a friendlier error message if "local.json" is not writable (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd9badba14786: Give "bin/config" a friendlier error message if "local.json" is not writable.

avivey mentioned this in D20788: Allow bin/config to create config file.Sep 7 2019, 7:18 PM

avivey mentioned this in rP318e8ebdac95: Allow bin/config to create config file.Sep 8 2019, 12:16 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

management/

PhabricatorConfigManagementSetWorkflow.php

15 lines

Diff 49545

View Options

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

Give "bin/config" a friendlier error message if "local.json" is not writableClosedPublicActions