Differential D20717

Update Phortune payment account interfaces to handle merchant vs customer views
ClosedPublic
Actions

Authored by epriestley on Aug 16 2019, 4:38 PM.

Details

Reviewers: None
Maniphest Tasks: T13366: Update Phortune to work better with "enterprise" billing/accounts departments
Commits: rP0cc7e8eeb850: Update Phortune payment account interfaces to handle merchant vs customer views

Summary

Depends on D20716. Ref T13366. This implements the new policy behavior cleanly in all top-level Phortune payment account interfaces.

Test Plan

As a merchant with an account relationship (not an account member) and an account member, browsed all account interfaces and attempted to perform edits. As a merchant, saw a reduced-strength view.

Diff Detail

Repository

rP Phabricator

Branch

merchant6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23258
Build 31951: Run Core Tests
Build 31950: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 16 2019, 4:38 PM

Harbormaster completed remote builds in B23258: Diff 49398.Aug 16 2019, 4:39 PM

epriestley requested review of this revision.Aug 16 2019, 4:39 PM

epriestley added a child revision: D20718: Update PhortunePaymentMethod for modern policy interfaces.Aug 16 2019, 5:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2019, 4:02 AM

Closed by commit rP0cc7e8eeb850: Update Phortune payment account interfaces to handle merchant vs customer views (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0cc7e8eeb850: Update Phortune payment account interfaces to handle merchant vs customer views.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

phortune/

application/

PhabricatorPhortuneApplication.php

12 lines

controller/

account/

PhortuneAccountAddManagerController.php

41 lines

PhortuneAccountChargeListController.php

PhortuneAccountChargesController.php

16 lines

PhortuneAccountController.php

136 lines

PhortuneAccountDetailsController.php

11 lines

PhortuneAccountEmailAddressesController.php

16 lines

PhortuneAccountEmailEditController.php

20 lines

PhortuneAccountEmailViewController.php

14 lines

PhortuneAccountManagersController.php

23 lines

PhortuneAccountOrdersController.php

17 lines

PhortuneAccountOverviewController.php

11 lines

PhortuneAccountPaymentMethodsController.php

16 lines

PhortuneAccountProfileController.php

39 lines

PhortuneAccountSubscriptionController.php

24 lines

	charge/
	account/

	PhortuneChargeListController.php
	PhortuneAccountChargeListController.php

2 lines

storage/

PhortuneAccount.php

14 lines

PhortuneAccountEmail.php

3 lines

view/

layout/

AphrontSideNavFilterView.php

5 lines

Diff 49398

View Options

src/__phutil_library_map__.php

View Options

src/applications/phortune/application/PhabricatorPhortuneApplication.php

View Options

src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountChargeListController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountChargesController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountDetailsController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountEmailAddressesController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountEmailEditController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountEmailViewController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountManagersController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountOrdersController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountOverviewController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountPaymentMethodsController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountProfileController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php

View Options

src/applications/phortune/controller/charge/PhortuneChargeListController.php

View Options

src/applications/phortune/storage/PhortuneAccount.php

View Options

src/applications/phortune/storage/PhortuneAccountEmail.php

View Options

src/view/layout/AphrontSideNavFilterView.php

Update Phortune payment account interfaces to handle merchant vs customer viewsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49398

src/__phutil_library_map__.php

src/applications/phortune/application/PhabricatorPhortuneApplication.php

src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php

src/applications/phortune/controller/account/PhortuneAccountChargeListController.php

src/applications/phortune/controller/account/PhortuneAccountChargesController.php

src/applications/phortune/controller/account/PhortuneAccountController.php

src/applications/phortune/controller/account/PhortuneAccountDetailsController.php

src/applications/phortune/controller/account/PhortuneAccountEmailAddressesController.php

src/applications/phortune/controller/account/PhortuneAccountEmailEditController.php

src/applications/phortune/controller/account/PhortuneAccountEmailViewController.php

src/applications/phortune/controller/account/PhortuneAccountManagersController.php

src/applications/phortune/controller/account/PhortuneAccountOrdersController.php

src/applications/phortune/controller/account/PhortuneAccountOverviewController.php

src/applications/phortune/controller/account/PhortuneAccountPaymentMethodsController.php

src/applications/phortune/controller/account/PhortuneAccountProfileController.php

src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php

src/applications/phortune/controller/charge/PhortuneChargeListController.php

src/applications/phortune/storage/PhortuneAccount.php

src/applications/phortune/storage/PhortuneAccountEmail.php

src/view/layout/AphrontSideNavFilterView.php

Update Phortune payment account interfaces to handle merchant vs customer views
ClosedPublic
Actions

Revision Contents
Changeset List