Page MenuHomePhabricator

When parsing HTML in remarkup, always start a new tag when encountering "<"
ClosedPublic

Authored by epriestley on Jul 2 2019, 12:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 5:22 PM
Unknown Object (File)
Tue, Mar 5, 1:51 AM
Unknown Object (File)
Mon, Mar 4, 5:55 PM
Unknown Object (File)
Feb 19 2024, 12:12 PM
Unknown Object (File)
Feb 3 2024, 10:47 PM
Unknown Object (File)
Feb 3 2024, 3:53 PM
Unknown Object (File)
Jan 12 2024, 7:49 AM
Unknown Object (File)
Jan 2 2024, 5:23 PM
Subscribers
None

Details

Summary

Depends on D20630. See https://discourse.phabricator-community.org/t/bug-in-src-parser-html-phutildomnode-php/2882/. Currently, we parse <x>1<2</x> as an <x> tag containing a <2</x> tag.

A more expected interpretation of this is a single <x> tag containing the content 1<2.

When we encounter a <, always start a new tag, even if we're currently in a tag.

Test Plan

Added a test and made it pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable