Page MenuHomePhabricator

When parsing HTML in remarkup, always start a new tag when encountering "<"
ClosedPublic

Authored by epriestley on Jul 2 2019, 12:11 AM.
Tags
None
Referenced Files
F15283168: D20631.diff
Tue, Mar 4, 5:44 AM
Unknown Object (File)
Wed, Feb 26, 3:02 PM
Unknown Object (File)
Tue, Feb 18, 8:26 AM
Unknown Object (File)
Fri, Feb 14, 8:47 PM
Unknown Object (File)
Feb 11 2025, 4:00 AM
Unknown Object (File)
Feb 10 2025, 5:05 AM
Unknown Object (File)
Feb 10 2025, 5:05 AM
Unknown Object (File)
Feb 10 2025, 5:04 AM
Subscribers
None

Details

Summary

Depends on D20630. See https://discourse.phabricator-community.org/t/bug-in-src-parser-html-phutildomnode-php/2882/. Currently, we parse <x>1<2</x> as an <x> tag containing a <2</x> tag.

A more expected interpretation of this is a single <x> tag containing the content 1<2.

When we encounter a <, always start a new tag, even if we're currently in a tag.

Test Plan

Added a test and made it pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable