Page MenuHomePhabricator
Differential D20567

Add "bin/herald rule ..." to modify Herald rules from the CLI
ClosedPublic
Actions

Authored by epriestley on May 31 2019, 2:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 29, 1:13 PM
Unknown Object (File)
Fri, Mar 29, 12:54 PM
Unknown Object (File)
Sat, Mar 23, 12:40 PM
Unknown Object (File)
Sat, Mar 23, 12:40 PM
Unknown Object (File)
Mar 5 2024, 4:07 PM
Unknown Object (File)
Mar 3 2024, 9:36 PM
Unknown Object (File)
Feb 11 2024, 10:36 PM
Unknown Object (File)
Feb 9 2024, 1:57 PM
View All Files
Subscribers
jmeador

Details

Reviewers
amckinley
Maniphest Tasks
T13298: Improve Herald profiling information available in transcripts
Commits
rPd7890d08b828: Add "bin/herald rule ..." to modify Herald rules from the CLI
Summary

Depends on D20566. Ref T13298. See PHI1280. Currently, there's no clean way to disable problematic personal rules. This comes up occasionally and sometimes isn't really the best approach to solving a problem, but is a generally reasonable capability to provide.

Allow Herald rules (including personal rules) to be disabled/enabled via bin/herald rule ... --disable/--enable.

Test Plan

Used the CLI to disable and enable a personal rule.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 31 2019, 2:59 PM
Harbormaster completed remote builds in B22935: Diff 49060.May 31 2019, 3:01 PM
epriestley requested review of this revision.May 31 2019, 3:01 PM
jmeador added a subscriber: jmeador.May 31 2019, 4:30 PM
jmeador added inline comments.
src/applications/herald/management/HeraldRuleManagementWorkflow.php
39

Not sure if there's a translation here, but the grammar seems a bit icky.

78

Assuming exmaple is the British spelling of example.

epriestley updated this revision to Diff 49061.May 31 2019, 4:32 PM
  • Wordsmithing.
Harbormaster completed remote builds in B22936: Diff 49061.May 31 2019, 4:33 PM
amckinley accepted this revision.Jun 2 2019, 8:33 AM
amckinley added inline comments.
src/applications/herald/management/HeraldRuleManagementWorkflow.php
39

Yeah, "a rule" seems to have been the intent.

This revision is now accepted and ready to land.Jun 2 2019, 8:33 AM
epriestley added a comment.EditedJun 2 2019, 2:30 PM

Oh, I edited "an to edit" into "an rule to edit" or something. Perhaps not my greatest work.

epriestley updated this revision to Diff 49064.Jun 4 2019, 2:02 PM
  • More wordsmithing.
Harbormaster completed remote builds in B22939: Diff 49064.Jun 4 2019, 2:04 PM
Closed by commit rPd7890d08b828: Add "bin/herald rule ..." to modify Herald rules from the CLI (authored by epriestley). · Explain WhyJun 4 2019, 2:12 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPd7890d08b828: Add "bin/herald rule ..." to modify Herald rules from the CLI.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
management/
106 lines

Diff 49065

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/management/HeraldRuleManagementWorkflow.php

Loading...
Phabricator · Built by Phacility