Paths

Table of Contentst

Differential D20539

Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion
ClosedPublic
Actions

Authored by epriestley on May 21 2019, 7:01 PM.

Tags

None

Referenced Files

	F13050858: D20539.id48983.diff
	Fri, Apr 19, 3:14 AM

	F13050857: D20539.id48970.diff
	Fri, Apr 19, 3:14 AM

	F13050856: D20539.id.diff
	Fri, Apr 19, 3:14 AM

	Unknown Object (File)
	Tue, Apr 16, 2:25 PM

	Unknown Object (File)
	Thu, Apr 11, 8:29 AM

	Unknown Object (File)
	Thu, Apr 11, 4:21 AM

	Unknown Object (File)
	Thu, Apr 4, 1:18 AM

	Unknown Object (File)
	Tue, Apr 2, 4:05 PM

Subscribers

Tokens

"Mountain of Wealth" token, awarded by 20after4.

Details

Reviewers

Maniphest Tasks

T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion

Commits

rP4180b337cf7e: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference…

Summary

Depends on D20538. Ref T13291. We now recognize full source URIs, but encoding full URIs isn't super human-friendly and we can't do stuff like relative links with them. Add {src ...} as a way to get to this behavior that supports options and more flexible syntax.

Test Plan

Screen Shot 2019-05-21 at 11.55.47 AM.png (590×659 px, 52 KB)

Diff Detail

Repository

Branch

src2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22846
Build 31346: Run Core Tests
Build 31345: arc lint + arc unit

Event Timeline

epriestley created this revision.May 21 2019, 7:01 PM

Harbormaster completed remote builds in B22846: Diff 48970.May 21 2019, 7:02 PM

epriestley requested review of this revision.May 21 2019, 7:02 PM

amckinley accepted this revision.May 21 2019, 7:22 PM

This revision is now accepted and ready to land.May 21 2019, 7:22 PM

Closed by commit rP4180b337cf7e: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference… (authored by epriestley). · Explain WhyMay 21 2019, 8:12 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP4180b337cf7e: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference….

I've been wishing for this literally forever. If I could award more mountains of wealth tokens, I most certainly would!

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

diffusion/

application/

PhabricatorDiffusionApplication.php

1 line

remarkup/

DiffusionSourceLinkRemarkupRule.php

221 lines

Diff 48970

src/__phutil_library_map__.php

Loading...

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...

src/applications/diffusion/remarkup/DiffusionSourceLinkRemarkupRule.php

Loading...