Page MenuHomePhabricator

Allow `setCustomSeverityRules` to be overridden in subclasses
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:18 AM.
Tags
None
Referenced Files
F12813684: D20514.id.diff
Thu, Mar 28, 1:21 AM
Unknown Object (File)
Sat, Mar 23, 12:47 AM
Unknown Object (File)
Sat, Mar 23, 12:45 AM
Unknown Object (File)
Sat, Mar 23, 12:45 AM
Unknown Object (File)
Sat, Mar 23, 12:45 AM
Unknown Object (File)
Sat, Mar 16, 11:09 AM
Unknown Object (File)
Mon, Mar 4, 7:12 PM
Unknown Object (File)
Fri, Mar 1, 5:23 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |ArcanistDockerContainerLinterProxy]] from [[https://github.com/freelancer/flarc | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove a TODO comment that is no longer relevant

This revision is now accepted and ready to land.May 14 2019, 2:10 PM