Allow `setCustomSeverityRules` to be overridden in subclasses
ClosedPublic
Actions

Authored by joshuaspence on May 13 2019, 4:18 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |ArcanistDockerContainerLinterProxy]] from [[https://github.com/freelancer/flarc | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

	Time	Test
	50 ms	ArcanistPyFlakesLinterTestCase::testVersion Assertion failed, expected 'true' (at ArcanistExternalLinterTestCase.php:10): Failed to parse version from command. ACTUAL VALUE
	29 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::testLinter 7 assertions passed.
	12 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::testLinter 3 assertions passed.
	12 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::testLinter 4 assertions passed.
	12 ms	ArcanistArrayCombineXHPASTLinterRuleTestCase::testLinter 3 assertions passed.
		View Full Test Results (1 Failed · 197 Passed · 62 Skipped)