Page MenuHomePhabricator

Allow `setCustomSeverityRules` to be overridden in subclasses
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:18 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see ArcanistDockerContainerLinterProxy from flarc). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint OK
Unit
Unit Test Errors
Build Status
Buildable 22780
Build 31247: Run Core Tests
Build 31246: arc lint + arc unit

Unit TestsFailed

Excuse: Unrelated
TimeTest
50 msArcanistPyFlakesLinterTestCase::testVersion
Assertion failed, expected 'true' (at ArcanistExternalLinterTestCase.php:10): Failed to parse version from command. ACTUAL VALUE
29 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::testLinter
7 assertions passed.
12 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::testLinter
3 assertions passed.
12 msArcanistAliasFunctionXHPASTLinterRuleTestCase::testLinter
4 assertions passed.
12 msArcanistArrayCombineXHPASTLinterRuleTestCase::testLinter
3 assertions passed.
View Full Test Results (1 Failed · 197 Passed · 62 Skipped)

Event Timeline

joshuaspence created this revision.May 13 2019, 4:18 AM
joshuaspence requested review of this revision.May 13 2019, 4:19 AM

Remove a TODO comment that is no longer relevant

joshuaspence edited the summary of this revision. (Show Details)May 14 2019, 12:30 AM
epriestley accepted this revision.May 14 2019, 2:10 PM
This revision is now accepted and ready to land.May 14 2019, 2:10 PM