Differential D20510

When a user pastes a Phabricator URI into the search box, redirect to the URI
ClosedPublic
Actions

Authored by epriestley on May 9 2019, 6:23 PM.

Details

Reviewers

amckinley
joshuaspence

Maniphest Tasks

T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does)

Summary

Depends on D20509. See PHI1224. Ref T5378. With some frequency, I paste URIs into the global search input (I am dumb).

When I do this dumb thing, redirect to the URI as though the global search was a URI bar.

Maybe only I am dumb like this, but I don't think it'll hurt anything.

Test Plan

pasted a URI and hit return; tried to eat a rock

Diff Detail

Repository

rP Phabricator

Branch

sref2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22776
Build 31239: Run Core Tests
Build 31238: arc lint + arc unit

Event Timeline

epriestley created this revision.May 9 2019, 6:23 PM

Harbormaster completed remote builds in B22776: Diff 48903.May 9 2019, 6:24 PM

epriestley requested review of this revision.May 9 2019, 6:24 PM

epriestley added a child revision: D20512: Specialize rendering of self-URIs in the form "/X123".May 9 2019, 8:34 PM

joshuaspence accepted this revision.May 14 2019, 12:39 AM

This revision is now accepted and ready to land.May 14 2019, 12:39 AM

Closed by commit rP706826bf022f: When a user pastes a Phabricator URI into the search box, redirect to the URI (authored by epriestley). · Explain WhyMay 16 2019, 6:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley added an edge: rP706826bf022f: When a user pastes a Phabricator URI into the search box, redirect to the URI.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

meta/

engineextension/

PhabricatorDatasourceURIEngineExtension.php

34 lines

Diff 48903

View Options

src/__phutil_library_map__.php