Page MenuHomePhabricator

Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class
ClosedPublic

Authored by epriestley on May 9 2019, 6:14 PM.
Tags
None
Referenced Files
F14075355: D20509.diff
Thu, Nov 21, 10:48 AM
Unknown Object (File)
Sun, Nov 17, 7:11 AM
Unknown Object (File)
Mon, Oct 28, 6:51 PM
Unknown Object (File)
Wed, Oct 23, 8:32 PM
Unknown Object (File)
Oct 18 2024, 3:10 AM
Unknown Object (File)
Oct 9 2024, 12:20 PM
Unknown Object (File)
Sep 6 2024, 6:23 AM
Unknown Object (File)
Sep 4 2024, 11:04 AM
Subscribers
None

Details

Summary

Ref T5378. This class was renamed more than a year ago, in D19087. Remove the leftover compatiblity layer.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
sref1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22775
Build 31237: Run Core Tests
Build 31236: arc lint + arc unit

Event Timeline

I didn't go all the way down the rabbit hole on this, but it's not immediately obvious to me that this is actually relevant to T5378.

This revision is now accepted and ready to land.May 16 2019, 12:57 PM

Oh, the relevance is that PhabricatorDatasourceEngineExtension now handles "doing magic stuff when you type things into the global search bar" (like jumping to a task when you type T123), and the next change was making "type a URI" mean "navigate to that uri" -- which got a mention in T5378, although it isn't the primary focus of that task.