Page MenuHomePhabricator
Differential D19087

Rename "QuickSearch" Engine/EngineExtension to "Datasource"
ClosedPublic
Actions

Authored by epriestley on Feb 14 2018, 11:38 PM.
Tags
None
Referenced Files
F15448455: D19087.id45752.diff
Fri, Mar 28, 5:00 AM
F15442437: D19087.diff
Wed, Mar 26, 11:25 PM
F15437067: D19087.id.diff
Tue, Mar 25, 5:19 PM
F15429994: D19087.diff
Mon, Mar 24, 5:10 AM
F15423837: D19087.id45748.diff
Sat, Mar 22, 6:49 PM
F15375149: D19087.id45748.diff
Wed, Mar 12, 9:53 PM
F15360626: D19087.id45752.diff
Tue, Mar 11, 9:15 AM
F15341998: D19087.id45752.diff
Sun, Mar 9, 9:01 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13079: Allow third-party code to extend the list of functions that function datasources support
Commits
rPabe5fd57b0de: Rename "QuickSearch" Engine/EngineExtension to "Datasource"
Summary

Ref T13079. This recently-introduced Engine/EngineExtension are a good fit for adding more datasource functions in general, but we didn't think quite big enough in naming them.

Test Plan

Used quick search typeahead, hit applications/users/monograms/symbols/etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
28 lines
applications/
diffusion/
engineextension/
DiffusionDatasourceEngineExtension.php
DiffusionQuickSearchEngineExtension.php
4 lines
meta/
engineextension/
PhabricatorDatasourceApplicationEngineExtension.php
PhabricatorQuickSearchApplicationEngineExtension.php
4 lines
people/
engineextension/
PhabricatorPeopleDatasourceEngineExtension.php
PhabricatorPeopleQuickSearchEngineExtension.php
4 lines
project/
engineextension/
ProjectDatasourceEngineExtension.php
ProjectQuickSearchEngineExtension.php
4 lines
search/
engine/
8 lines
engineextension/
PhabricatorDatasourceEngineExtension.php
PhabricatorQuickSearchEngineExtension.php
5 lines
20 lines
typeahead/
4 lines
typeahead/
engineextension/
PhabricatorMonogramDatasourceEngineExtension.php
PhabricatorMonogramQuickSearchEngineExtension.php
4 lines

Diff 45752

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/engineextension/DiffusionDatasourceEngineExtension.php

Loading...
View Options

src/applications/diffusion/engineextension/DiffusionQuickSearchEngineExtension.php

Loading...
View Options

src/applications/meta/engineextension/PhabricatorDatasourceApplicationEngineExtension.php

Loading...
View Options

src/applications/meta/engineextension/PhabricatorQuickSearchApplicationEngineExtension.php

Loading...
View Options

src/applications/people/engineextension/PhabricatorPeopleDatasourceEngineExtension.php

Loading...
View Options

src/applications/people/engineextension/PhabricatorPeopleQuickSearchEngineExtension.php

Loading...
View Options

src/applications/project/engineextension/ProjectDatasourceEngineExtension.php

Loading...
View Options

src/applications/project/engineextension/ProjectQuickSearchEngineExtension.php

Loading...
View Options

src/applications/search/engine/PhabricatorDatasourceEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorQuickSearchEngine.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorDatasourceEngineExtension.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorQuickSearchEngineExtension.php

Loading...
View Options

src/applications/search/typeahead/PhabricatorSearchDatasource.php

Loading...
View Options

src/applications/typeahead/engineextension/PhabricatorMonogramDatasourceEngineExtension.php

Loading...
View Options

src/applications/typeahead/engineextension/PhabricatorMonogramQuickSearchEngineExtension.php

Loading...
Phabricator · Built by Phacility