Differential D19087

Rename "QuickSearch" Engine/EngineExtension to "Datasource"
ClosedPublic
Actions

Authored by epriestley on Feb 14 2018, 11:38 PM.

Details

Reviewers: None
Maniphest Tasks: T13079: Allow third-party code to extend the list of functions that function datasources support
Commits: rPabe5fd57b0de: Rename "QuickSearch" Engine/EngineExtension to "Datasource"

Summary

Ref T13079. This recently-introduced Engine/EngineExtension are a good fit for adding more datasource functions in general, but we didn't think quite big enough in naming them.

Test Plan

Used quick search typeahead, hit applications/users/monograms/symbols/etc.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 14 2018, 11:38 PM

Harbormaster completed remote builds in B19552: Diff 45748.Feb 14 2018, 11:39 PM

epriestley requested review of this revision.Feb 14 2018, 11:39 PM

epriestley added a child revision: D19088: Modularize the "jump nav" behaviors in global search.Feb 15 2018, 12:31 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2018, 2:03 AM

Closed by commit rPabe5fd57b0de: Rename "QuickSearch" Engine/EngineExtension to "Datasource" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D20509: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.May 9 2019, 6:14 PM

epriestley mentioned this in rPf2feb0378f54: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.May 16 2019, 6:14 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

28 lines

applications/

diffusion/

engineextension/

	DiffusionDatasourceEngineExtension.php
	DiffusionQuickSearchEngineExtension.php

4 lines

DiffusionQuickSearchEngineExtension.php

meta/

engineextension/

	PhabricatorDatasourceApplicationEngineExtension.php
	PhabricatorQuickSearchApplicationEngineExtension.php

4 lines

PhabricatorQuickSearchApplicationEngineExtension.php

people/

engineextension/

	PhabricatorPeopleDatasourceEngineExtension.php
	PhabricatorPeopleQuickSearchEngineExtension.php

4 lines

PhabricatorPeopleQuickSearchEngineExtension.php

project/

engineextension/

	ProjectDatasourceEngineExtension.php
	ProjectQuickSearchEngineExtension.php

4 lines

ProjectQuickSearchEngineExtension.php

search/

engine/

PhabricatorDatasourceEngine.php

8 lines

PhabricatorQuickSearchEngine.php

engineextension/

	PhabricatorDatasourceEngineExtension.php
	PhabricatorQuickSearchEngineExtension.php

5 lines

PhabricatorQuickSearchEngineExtension.php

20 lines

typeahead/

PhabricatorSearchDatasource.php

4 lines

typeahead/

engineextension/

	PhabricatorMonogramDatasourceEngineExtension.php
	PhabricatorMonogramQuickSearchEngineExtension.php

4 lines

PhabricatorMonogramQuickSearchEngineExtension.php

Diff 45752

View Options

src/__phutil_library_map__.php

View Options

src/applications/diffusion/engineextension/DiffusionDatasourceEngineExtension.php

View Options

src/applications/diffusion/engineextension/DiffusionQuickSearchEngineExtension.php

View Options

src/applications/meta/engineextension/PhabricatorDatasourceApplicationEngineExtension.php

View Options

src/applications/meta/engineextension/PhabricatorQuickSearchApplicationEngineExtension.php

View Options

src/applications/people/engineextension/PhabricatorPeopleDatasourceEngineExtension.php

View Options

src/applications/people/engineextension/PhabricatorPeopleQuickSearchEngineExtension.php

View Options

src/applications/project/engineextension/ProjectDatasourceEngineExtension.php

View Options

src/applications/project/engineextension/ProjectQuickSearchEngineExtension.php

View Options

src/applications/search/engine/PhabricatorDatasourceEngine.php

View Options

src/applications/search/engine/PhabricatorQuickSearchEngine.php

View Options

src/applications/search/engineextension/PhabricatorDatasourceEngineExtension.php

View Options

src/applications/search/engineextension/PhabricatorQuickSearchEngineExtension.php

View Options

src/applications/search/typeahead/PhabricatorSearchDatasource.php

View Options

src/applications/typeahead/engineextension/PhabricatorMonogramDatasourceEngineExtension.php

View Options

src/applications/typeahead/engineextension/PhabricatorMonogramQuickSearchEngineExtension.php

Rename "QuickSearch" Engine/EngineExtension to "Datasource"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45752

src/__phutil_library_map__.php

src/applications/diffusion/engineextension/DiffusionDatasourceEngineExtension.php

src/applications/diffusion/engineextension/DiffusionQuickSearchEngineExtension.php

src/applications/meta/engineextension/PhabricatorDatasourceApplicationEngineExtension.php

src/applications/meta/engineextension/PhabricatorQuickSearchApplicationEngineExtension.php

src/applications/people/engineextension/PhabricatorPeopleDatasourceEngineExtension.php

src/applications/people/engineextension/PhabricatorPeopleQuickSearchEngineExtension.php

src/applications/project/engineextension/ProjectDatasourceEngineExtension.php

src/applications/project/engineextension/ProjectQuickSearchEngineExtension.php

src/applications/search/engine/PhabricatorDatasourceEngine.php

src/applications/search/engine/PhabricatorQuickSearchEngine.php

src/applications/search/engineextension/PhabricatorDatasourceEngineExtension.php

src/applications/search/engineextension/PhabricatorQuickSearchEngineExtension.php

src/applications/search/typeahead/PhabricatorSearchDatasource.php

src/applications/typeahead/engineextension/PhabricatorMonogramDatasourceEngineExtension.php

src/applications/typeahead/engineextension/PhabricatorMonogramQuickSearchEngineExtension.php

Rename "QuickSearch" Engine/EngineExtension to "Datasource"
ClosedPublic
Actions

Revision Contents
Changeset List