Differential D20433

Deprecate "Track Only" in the Diffusion UI
ClosedPublic
Actions

Authored by epriestley on Apr 15 2019, 7:28 PM.

Details

Reviewers

Maniphest Tasks

T12967: Mercurical branches don't display tracking status properly
T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs"

Commits

rPc33f544e7417: Deprecate "Track Only" in the Diffusion UI

Summary

Depends on D20432. Ref T13277. Fixes T12967. Removes some "Track Only" hints and warns that the feature is deprecated in favor of "Permanent Refs" and "Fetch Only".

(This "fixes" T12967 by mooting it.)

Test Plan

Viewed "branches" sectino of the manage UI, edited "braches" section of a repository.

Diff Detail

Repository

rP Phabricator

Branch

autoclose14

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22605
Build 30975: Run Core Tests
Build 30974: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 15 2019, 7:28 PM

epriestley mentioned this in T12967: Mercurical branches don't display tracking status properly.Apr 15 2019, 7:29 PM

Harbormaster completed remote builds in B22605: Diff 48735.Apr 15 2019, 7:30 PM

epriestley requested review of this revision.Apr 15 2019, 7:30 PM

epriestley added a child revision: D20434: Update "Autoclose" documentation to focus on "Permanent Refs" instead.Apr 16 2019, 12:44 PM

amckinley accepted this revision.Apr 17 2019, 8:24 PM

This revision is now accepted and ready to land.Apr 17 2019, 8:24 PM

Closed by commit rPc33f544e7417: Deprecate "Track Only" in the Diffusion UI (authored by epriestley). · Explain WhyApr 18 2019, 12:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

editor/

DiffusionRepositoryEditEngine.php

28 lines

management/

DiffusionRepositoryBranchesManagementPanel.php

17 lines

Diff 48735

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php