Differential D20425

Move the repository "Publishing" option to the "Basics" panel in repository management
ClosedPublic
Actions

Authored by epriestley on Apr 15 2019, 1:29 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs"

Commits

rP7a4ef2bad876: Move the repository "Publishing" option to the "Basics" panel in repository…

Summary

Depends on D20424. Ref T13277. Now that the "Actions" panel only has one item ("Publishing"), just move it to the "Basics" panel.

Update the UI to show active/publishing status more clearly and relate them to one another and importing state.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

autoclose9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22597
Build 30959: Run Core Tests
Build 30958: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 15 2019, 1:29 PM

Harbormaster completed remote builds in B22597: Diff 48727.Apr 15 2019, 1:31 PM

epriestley requested review of this revision.Apr 15 2019, 1:31 PM

epriestley added a child revision: D20426: Expose repository ref rules via "diffusion.repository.search".Apr 15 2019, 1:57 PM

amckinley accepted this revision.Apr 17 2019, 7:58 PM

amckinley added inline comments.

src/applications/diffusion/controller/DiffusionRepositoryEditPublishingController.php
47	Extra "or".
61	Add a "Note: existing unpublished commits will not be published"?

This revision is now accepted and ready to land.Apr 17 2019, 7:58 PM

Wordsmithing.
Clarify that "reactivate" is not retroactive.

Harbormaster completed remote builds in B22651: Diff 48779.Apr 18 2019, 12:23 PM

Closed by commit rP7a4ef2bad876: Move the repository "Publishing" option to the "Basics" panel in repository… (authored by epriestley). · Explain WhyApr 18 2019, 12:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

diffusion/

application/

PhabricatorDiffusionApplication.php

1 line

controller/

DiffusionRepositoryController.php

2 lines

DiffusionRepositoryEditPublishingController.php

77 lines

management/

DiffusionRepositoryBasicsManagementPanel.php

105 lines

DiffusionRepositoryPublishingManagementPanel.php

Diff 48727

View Options

src/__phutil_library_map__.php

View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditPublishingController.php

View Options

src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryPublishingManagementPanel.php

Move the repository "Publishing" option to the "Basics" panel in repository managementClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48727

src/__phutil_library_map__.php

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

src/applications/diffusion/controller/DiffusionRepositoryController.php

src/applications/diffusion/controller/DiffusionRepositoryEditPublishingController.php

src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryPublishingManagementPanel.php

Move the repository "Publishing" option to the "Basics" panel in repository management
ClosedPublic
Actions

Revision Contents
Changeset List