Page MenuHomePhabricator

Allow users to add "ProfileMenu" items on mobile
ClosedPublic

Authored by epriestley on Mar 27 2019, 9:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:38 AM
Unknown Object (File)
Wed, Apr 10, 2:45 PM
Unknown Object (File)
Wed, Apr 3, 10:54 AM
Unknown Object (File)
Mon, Apr 1, 10:49 PM
Unknown Object (File)
Mon, Apr 1, 5:33 PM
Unknown Object (File)
Mon, Apr 1, 5:33 PM
Unknown Object (File)
Thu, Mar 28, 9:36 PM
Unknown Object (File)
Mar 16 2024, 5:00 AM
Subscribers
None

Details

Summary

Depends on D20337. Fixes T12167. Ref T13272. On this page ("Favorites > Edit Favorites > Personal", for example) the curtain actions aren't available on mobile.

Normally, curtains are built with Controller->newCurtainView(), which sets an ID on the action list, which populates the header button. This curtain is built directly because there's no Controller handy.

To fix the issue, just set an ID. This could probably be cleaner, but that's likely a much more involved change.

Test Plan

Edited my favorites, narrowed the window, saw an "Actions" button.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/search/engine/PhabricatorProfileMenuEngine.php
920–921

(This and the other thing below are unused.)

This revision is now accepted and ready to land.Mar 27 2019, 9:34 PM
This revision was automatically updated to reflect the committed changes.