Paths

Table of Contentst

Differential D20317

Fix transaction queries failing on "withIDs()" after clicking "Show Older"
ClosedPublic
Actions

Authored by epriestley on Mar 24 2019, 2:52 PM.

Tags

None

Referenced Files

	F14844154: D20317.diff
	Sun, Feb 2, 1:37 PM

	F14842030: D20317.diff
	Sat, Feb 1, 8:25 PM

	Unknown Object (File)
	Thu, Jan 23, 6:50 AM

	Unknown Object (File)
	Thu, Jan 16, 12:22 PM

	Unknown Object (File)
	Jan 1 2025, 5:29 AM

	Unknown Object (File)
	Dec 28 2024, 4:03 PM

	Unknown Object (File)
	Dec 15 2024, 3:39 PM

	Unknown Object (File)
	Dec 13 2024, 9:43 PM

Subscribers

None

Details

Reviewers

amckinley
avivey

Commits

rPe51381e2d6fa: (stable) Fix transaction queries failing on "withIDs()" after clicking "Show…
rPb82557073492: Fix transaction queries failing on "withIDs()" after clicking "Show Older"

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-on-show-older-changes/2545/.

Before T13266, this query got away without having real paging because it used simple ID paging only and results are never actually hidden (today, you can always see all transactions on an object).

Provide withIDs() so the new, slightly stricter paging works.

Test Plan

On an object with "Show Older" in the transaction record, clicked the link. Before: exception in paging code (see Discourse link above). After: transactions loaded cleanly.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 24 2019, 2:52 PM

Harbormaster completed remote builds in B22340: Diff 48471.Mar 24 2019, 2:54 PM

epriestley requested review of this revision.Mar 24 2019, 2:54 PM

avivey accepted this revision.Mar 24 2019, 6:45 PM

This revision is now accepted and ready to land.Mar 24 2019, 6:45 PM

Closed by commit rPb82557073492: Fix transaction queries failing on "withIDs()" after clicking "Show Older" (authored by epriestley). · Explain WhyMar 24 2019, 7:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

query/

PhabricatorApplicationTransactionQuery.php

13 lines

Diff 48472

src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php

Loading...