Page MenuHomePhabricator
Differential D20317

Fix transaction queries failing on "withIDs()" after clicking "Show Older"
ClosedPublic
Actions

Authored by epriestley on Mar 24 2019, 2:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 16, 12:22 PM
Unknown Object (File)
Wed, Jan 1, 5:29 AM
Unknown Object (File)
Sat, Dec 28, 4:03 PM
Unknown Object (File)
Dec 15 2024, 3:39 PM
Unknown Object (File)
Dec 13 2024, 9:43 PM
Unknown Object (File)
Dec 12 2024, 10:43 PM
Unknown Object (File)
Dec 12 2024, 10:43 PM
Unknown Object (File)
Dec 12 2024, 10:43 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
avivey
Commits
rPe51381e2d6fa: (stable) Fix transaction queries failing on "withIDs()" after clicking "Show…
rPb82557073492: Fix transaction queries failing on "withIDs()" after clicking "Show Older"
Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-on-show-older-changes/2545/.

Before T13266, this query got away without having real paging because it used simple ID paging only and results are never actually hidden (today, you can always see all transactions on an object).

Provide withIDs() so the new, slightly stricter paging works.

Test Plan

On an object with "Show Older" in the transaction record, clicked the link. Before: exception in paging code (see Discourse link above). After: transactions loaded cleanly.

Diff Detail

Repository
rP Phabricator
Branch
xactionid1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22340
Build 30567: Run Core Tests
Build 30566: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
query/
13 lines

Diff 48471

View Options

src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php

Loading...
Phabricator · Built by Phacility