Page MenuHomePhabricator

Add a warning to revision timelines when changes land with ongoing or failed builds
ClosedPublic

Authored by epriestley on Mar 1 2019, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 5:49 PM
Unknown Object (File)
Mon, Mar 11, 10:53 AM
Unknown Object (File)
Feb 9 2024, 6:28 PM
Unknown Object (File)
Feb 8 2024, 2:47 AM
Unknown Object (File)
Dec 22 2023, 4:34 PM
Unknown Object (File)
Dec 12 2023, 3:42 AM
Unknown Object (File)
Dec 8 2023, 1:40 PM
Unknown Object (File)
Nov 30 2023, 3:59 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13258. The general idea here is "if arc land prompted you and you hit 'y', you get a warning about it on the timeline".

This is similar to the existing warning about landing revisions in the wrong state and hitting "y" to get through that. See D18808, previously.

These warnings make it easier to catch process issues at a glance, especially because the overall build status is now more complicated (and may legally include some failures on tests which are marked as unimportant).

The transaction stores which builds had problems, but I'm not doing anything to render that for now. I think you can usually figure it out from the UI already; if not, we could refine this.

Test Plan
  • Used bin/differential attach-commit to trigger extraction/attachment.
  • Attached a commit to a revision with various build states, and various build plan "Warn When Landing" flags.
  • Got sensible warnings and non-warnings based on "Warn When Landing" setting.

Screen Shot 2019-03-01 at 7.49.43 AM.png (181×562 px, 20 KB)

Diff Detail

Repository
rP Phabricator
Branch
harbor11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22167
Build 30297: Run Core Tests
Build 30296: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 1 2019, 3:54 PM
amckinley added inline comments.
src/applications/differential/engine/DifferentialDiffExtractionEngine.php
401

"convenient"

This revision is now accepted and ready to land.Mar 5 2019, 6:41 PM
This revision was automatically updated to reflect the committed changes.