Page MenuHomePhabricator
Differential D20219

Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds and ends
ClosedPublic
Actions

Authored by epriestley on Feb 26 2019, 1:49 PM.
Tags
None
Referenced Files
F14843525: D20219.diff
Sun, Feb 2, 7:30 AM
Unknown Object (File)
Tue, Jan 28, 2:09 PM
Unknown Object (File)
Tue, Jan 28, 4:55 AM
Unknown Object (File)
Tue, Jan 28, 4:55 AM
Unknown Object (File)
Tue, Jan 28, 4:55 AM
Unknown Object (File)
Sat, Jan 25, 4:14 PM
Unknown Object (File)
Sat, Jan 25, 3:56 AM
Unknown Object (File)
Sat, Jan 25, 3:56 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
amckinley
Maniphest Tasks
T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc)
Commits
rP620047bcfe3f: Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds…
Summary

Depends on D20218. Ref T13258. It's somewhat cumbersome to get from build plans to related builds but this is a reasonable thing to want to do, so make it a little easier.

Also clean up / standardize / hint a few things a little better.

Test Plan

Screen Shot 2019-02-26 at 5.47.11 AM.png (191×1 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
harbor4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22130
Build 30237: Run Core Tests
Build 30236: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
92 lines
query/
51 lines
storage/
build/
4 lines
configuration/
2 lines
view/
67 lines

Diff 48268

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterBuildView.php

Loading...
Phabricator · Built by Phacility