Page MenuHomePhabricator

Add more type checking to transactions queued by Herald
ClosedPublic

Authored by epriestley on Feb 26 2019, 3:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 3:35 AM
Unknown Object (File)
Sat, Apr 6, 9:50 PM
Unknown Object (File)
Sat, Apr 6, 8:59 PM
Unknown Object (File)
Mon, Apr 1, 2:06 AM
Unknown Object (File)
Mon, Apr 1, 2:06 AM
Unknown Object (File)
Mon, Apr 1, 2:06 AM
Unknown Object (File)
Mon, Apr 1, 2:06 AM
Unknown Object (File)
Mar 20 2024, 3:45 PM
Subscribers
None

Details

Summary

See PHI1096. Depends on D20213. An install is reporting a hard-to-reproduce issue where a non-transaction gets queued by Herald somehow. This might be in third-party code.

Sprinkle the relevant parts of the code with final and type checking to try to catch the problem before it causes a fatal we can't pull a stack trace out of.

Test Plan

Poked around locally (e.g., edited revisions to cause Herald to trigger), but hard to know if this will do what it's supposed to or not without deploying and seeing if it catches anything.

Diff Detail

Repository
rP Phabricator
Branch
types1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22125
Build 30227: Run Core Tests
Build 30226: arc lint + arc unit