Page MenuHomePhabricator

Add more type checking to transactions queued by Herald
ClosedPublic

Authored by epriestley on Feb 26 2019, 3:51 AM.

Details

Summary

See PHI1096. Depends on D20213. An install is reporting a hard-to-reproduce issue where a non-transaction gets queued by Herald somehow. This might be in third-party code.

Sprinkle the relevant parts of the code with final and type checking to try to catch the problem before it causes a fatal we can't pull a stack trace out of.

Test Plan

Poked around locally (e.g., edited revisions to cause Herald to trigger), but hard to know if this will do what it's supposed to or not without deploying and seeing if it catches anything.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 26 2019, 3:51 AM
epriestley requested review of this revision.Feb 26 2019, 3:52 AM
amckinley accepted this revision.Feb 26 2019, 3:53 PM
This revision is now accepted and ready to land.Feb 26 2019, 3:53 PM
This revision was automatically updated to reflect the committed changes.