Page MenuHomePhabricator

Add more type checking to transactions queued by Herald
ClosedPublic

Authored by epriestley on Feb 26 2019, 3:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 17 2026, 6:24 PM
Unknown Object (File)
Feb 8 2026, 12:47 AM
Unknown Object (File)
Dec 27 2025, 11:55 PM
Unknown Object (File)
Dec 23 2025, 12:45 PM
Unknown Object (File)
Dec 23 2025, 5:11 AM
Unknown Object (File)
Dec 22 2025, 12:39 PM
Unknown Object (File)
Nov 25 2025, 2:50 AM
Unknown Object (File)
Nov 22 2025, 4:22 PM
Subscribers
None

Details

Summary

See PHI1096. Depends on D20213. An install is reporting a hard-to-reproduce issue where a non-transaction gets queued by Herald somehow. This might be in third-party code.

Sprinkle the relevant parts of the code with final and type checking to try to catch the problem before it causes a fatal we can't pull a stack trace out of.

Test Plan

Poked around locally (e.g., edited revisions to cause Herald to trigger), but hard to know if this will do what it's supposed to or not without deploying and seeing if it catches anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable