Differential D20215

"
ClosedPublic
Actions

Authored by epriestley on Feb 26 2019, 4:09 AM.

Tags

None

Referenced Files

	F18777942: D20215.id.diff
	Sat, Oct 11, 6:41 AM

	F18672156: D20215.id48276.diff
	Thu, Sep 25, 6:49 AM

	F18629812: D20215.diff
	Sep 16 2025, 9:58 AM

	F18082690: D20215.id48276.diff
	Aug 5 2025, 7:06 AM

	F17946789: D20215.id48264.diff
	Jul 31 2025, 3:09 PM

	F17929427: D20215.id.diff
	Jul 30 2025, 5:07 PM

	F17901295: D20215.diff
	Jul 29 2025, 9:34 AM

	F17711995: D20215.diff
	Jul 17 2025, 9:21 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPb28b05342bcc: Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/"

Summary

Depends on D20213. Simplify this idiom.

Test Plan

Squinted hard; grep array_keys | grep range.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 26 2019, 4:09 AM

Harbormaster completed remote builds in B22126: Diff 48264.Feb 26 2019, 4:11 AM

epriestley requested review of this revision.Feb 26 2019, 4:11 AM

amckinley accepted this revision.Feb 26 2019, 3:54 PM

This revision is now accepted and ready to land.Feb 26 2019, 3:54 PM

Closed by commit rPb28b05342bcc: Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/" (authored by epriestley). · Explain WhyFeb 28 2019, 3:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

type/

PhabricatorSetConfigType.php

2 lines

Diff 48276

View Options

src/applications/config/type/PhabricatorSetConfigType.php

Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/"ClosedPublicActions