Differential D20215

"
ClosedPublic
Actions

Authored by epriestley on Feb 26 2019, 4:09 AM.

Tags

None

Referenced Files

	F19921221: D20215.id48276.diff
	Mon, Apr 6, 3:04 AM

	F19921119: D20215.id48264.diff
	Mon, Apr 6, 2:14 AM

	F19914171: D20215.diff
	Fri, Apr 3, 8:23 AM

	F19914170: D20215.diff
	Fri, Apr 3, 8:18 AM

	F19914167: D20215.diff
	Fri, Apr 3, 8:18 AM

	F19907570: D20215.id48264.diff
	Wed, Apr 1, 11:34 AM

	F19907567: D20215.id48264.diff
	Wed, Apr 1, 11:34 AM

	F19897192: D20215.diff
	Sun, Mar 29, 6:57 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPb28b05342bcc: Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/"

Summary

Depends on D20213. Simplify this idiom.

Test Plan

Squinted hard; grep array_keys | grep range.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 26 2019, 4:09 AM

Harbormaster completed remote builds in B22126: Diff 48264.Feb 26 2019, 4:11 AM

epriestley requested review of this revision.Feb 26 2019, 4:11 AM

amckinley accepted this revision.Feb 26 2019, 3:54 PM

This revision is now accepted and ready to land.Feb 26 2019, 3:54 PM

Closed by commit rPb28b05342bcc: Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/" (authored by epriestley). · Explain WhyFeb 28 2019, 3:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

type/

PhabricatorSetConfigType.php

2 lines

Diff 48276

View Options

src/applications/config/type/PhabricatorSetConfigType.php

Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/"ClosedPublicActions