Page MenuHomePhabricator
Differential D20215

Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/"
ClosedPublic
Actions

Authored by epriestley on Feb 26 2019, 4:09 AM.

Details

Reviewers
amckinley
Commits
rPb28b05342bcc: Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/"
Summary

Depends on D20213. Simplify this idiom.

Test Plan

Squinted hard; grep array_keys | grep range.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 26 2019, 4:09 AM
epriestley requested review of this revision.Feb 26 2019, 4:11 AM
amckinley accepted this revision.Feb 26 2019, 3:54 PM
This revision is now accepted and ready to land.Feb 26 2019, 3:54 PM
Closed by commit rPb28b05342bcc: Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/" (authored by epriestley). · Explain WhyFeb 28 2019, 3:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48276

View Options

src/applications/config/type/PhabricatorSetConfigType.php

Loading...
Phabricator · Built by Phacility