Page MenuHomePhabricator

Add more type checking to transactions queued by Herald
ClosedPublic

Authored by epriestley on Feb 26 2019, 3:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 3:45 PM
Unknown Object (File)
Feb 16 2024, 8:25 AM
Unknown Object (File)
Jan 20 2024, 4:39 PM
Unknown Object (File)
Jan 16 2024, 5:10 PM
Unknown Object (File)
Jan 12 2024, 4:44 PM
Unknown Object (File)
Jan 1 2024, 5:24 PM
Unknown Object (File)
Dec 28 2023, 5:03 PM
Unknown Object (File)
Dec 25 2023, 3:34 AM
Subscribers
None

Details

Summary

See PHI1096. Depends on D20213. An install is reporting a hard-to-reproduce issue where a non-transaction gets queued by Herald somehow. This might be in third-party code.

Sprinkle the relevant parts of the code with final and type checking to try to catch the problem before it causes a fatal we can't pull a stack trace out of.

Test Plan

Poked around locally (e.g., edited revisions to cause Herald to trigger), but hard to know if this will do what it's supposed to or not without deploying and seeing if it catches anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable