Differential D20088

Give Duo MFA a stronger hint if users continue without answering the challenge
ClosedPublic
Actions

Authored by epriestley on Feb 5 2019, 2:41 AM.

Tags

None

Referenced Files

	F15463321: D20088.id47974.diff
	Tue, Apr 1, 10:27 PM

	F15452297: D20088.diff
	Sat, Mar 29, 3:39 AM

	F15428912: D20088.diff
	Sun, Mar 23, 11:17 PM

	F15335563: D20088.diff
	Mar 8 2025, 4:25 PM

	Unknown Object (File)
	Feb 9 2025, 7:04 AM

	Unknown Object (File)
	Jan 28 2025, 12:33 PM

	Unknown Object (File)
	Jan 25 2025, 3:28 AM

	Unknown Object (File)
	Jan 24 2025, 4:10 AM

Subscribers

None

Details

Reviewers

Commits

rP03eb989fd875: Give Duo MFA a stronger hint if users continue without answering the challenge

Summary

See PHI912. Also, clean up some leftover copy/pastey code here.

Test Plan

Screen Shot 2019-02-04 at 6.37.46 PM.png (420×881 px, 45 KB)

Diff Detail

Repository

Branch

duo1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21818
Build 29769: Run Core Tests
Build 29768: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 5 2019, 2:41 AM

epriestley added inline comments.Feb 5 2019, 2:43 AM

src/applications/auth/factor/PhabricatorDuoAuthFactor.php
678–712	This stuff came from SMS/TOTP but isn't relevant for Duo. We have to return an empty result to make some other code work, although perhaps some future followup could simplify this a bit further.

Harbormaster completed remote builds in B21818: Diff 47974.Feb 5 2019, 2:43 AM

epriestley requested review of this revision.Feb 5 2019, 2:43 AM

amckinley accepted this revision.Feb 5 2019, 8:08 PM

This revision is now accepted and ready to land.Feb 5 2019, 8:08 PM

Closed by commit rP03eb989fd875: Give Duo MFA a stronger hint if users continue without answering the challenge (authored by epriestley). · Explain WhyFeb 5 2019, 10:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

factor/

PhabricatorAuthFactor.php

29 lines

PhabricatorAuthFactorResult.php

10 lines

PhabricatorDuoAuthFactor.php

56 lines

storage/

PhabricatorAuthChallenge.php

10 lines

Diff 47974

src/applications/auth/factor/PhabricatorAuthFactor.php

Loading...

src/applications/auth/factor/PhabricatorAuthFactorResult.php

Loading...

src/applications/auth/factor/PhabricatorDuoAuthFactor.php

Loading...

src/applications/auth/storage/PhabricatorAuthChallenge.php

Loading...